refactor(editor): Enable @typescript-eslint/no-base-to-string lint ru…

…le, fix errors (no-changelog) (#9783)
n8n-io · Jun 18, 2024 · 7e44cd7 · 7e44cd7
1 parent e3cbce5
commit 7e44cd7
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 8 deletions.
diff --git a/packages/editor-ui/.eslintrc.js b/packages/editor-ui/.eslintrc.js
@@ -39,7 +39,6 @@ module.exports = {
 		'@typescript-eslint/restrict-plus-operands': 'warn',
 		'@typescript-eslint/ban-ts-comment': ['warn', { 'ts-ignore': true }],
 		'@typescript-eslint/no-redundant-type-constituents': 'warn',
-		'@typescript-eslint/no-base-to-string': 'warn',
 		'@typescript-eslint/no-unsafe-enum-comparison': 'warn',
 	},
 };
diff --git a/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue b/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue
@@ -887,8 +887,9 @@ export default defineComponent({
 					this.testedSuccessfully = false;
 				}
 
-				const usesExternalSecrets = Object.entries(credentialDetails.data || {}).some(([, value]) =>
-					/=.*\{\{[^}]*\$secrets\.[^}]+}}.*/.test(`${value}`),
+				const usesExternalSecrets = Object.entries(credentialDetails.data || {}).some(
+					([, value]) =>
+						typeof value !== 'object' && /=.*\{\{[^}]*\$secrets\.[^}]+}}.*/.test(`${value}`),
 				);
 
 				const trackProperties: ITelemetryTrackProperties = {

diff --git a/packages/editor-ui/src/components/RunDataAi/useAiContentParsers.ts b/packages/editor-ui/src/components/RunDataAi/useAiContentParsers.ts
@@ -132,7 +132,11 @@ const outputTypeParsers: {
 						} else if (content.id.includes('SystemMessage')) {
 							message = `**System Message:** ${message}`;
 						}
-						if (execData.action && execData.action !== 'getMessages') {
+						if (
+							execData.action &&
+							typeof execData.action !== 'object' &&
+							execData.action !== 'getMessages'
+						) {
 							message = `## Action: ${execData.action}\n\n${message}`;
 						}
 

diff --git a/packages/editor-ui/src/components/SettingsLogStreaming/EventDestinationSettingsModal.ee.vue b/packages/editor-ui/src/components/SettingsLogStreaming/EventDestinationSettingsModal.ee.vue
@@ -459,7 +459,7 @@ export default defineComponent({
 		onModalClose() {
 			if (!this.hasOnceBeenSaved) {
 				this.workflowsStore.removeNode(this.node);
-				if (this.nodeParameters.id) {
+				if (this.nodeParameters.id && typeof this.nodeParameters.id !== 'object') {
 					this.logStreamingStore.removeDestination(this.nodeParameters.id.toString());
 				}
 			}
@@ -480,7 +480,9 @@ export default defineComponent({
 				this.uiStore.stateIsDirty = false;
 
 				const destinationType = (
-					this.nodeParameters.__type ? `${this.nodeParameters.__type}` : 'unknown'
+					this.nodeParameters.__type && typeof this.nodeParameters.__type !== 'object'
+						? `${this.nodeParameters.__type}`
+						: 'unknown'
 				)
 					.replace('$$MessageEventBusDestination', '')
 					.toLowerCase();

diff --git a/packages/editor-ui/src/composables/useRunWorkflow.ts b/packages/editor-ui/src/composables/useRunWorkflow.ts
@@ -306,7 +306,8 @@ export function useRunWorkflow(useRunWorkflowOpts: { router: ReturnType<typeof u
 						if (!showForm) continue;
 
 						const { webhookSuffix } = (node.parameters.options ?? {}) as IDataObject;
-						const suffix = webhookSuffix ? `/${webhookSuffix}` : '';
+						const suffix =
+							webhookSuffix && typeof webhookSuffix !== 'object' ? `/${webhookSuffix}` : '';
 						testUrl = `${rootStore.getFormWaitingUrl}/${runWorkflowApiResponse.executionId}${suffix}`;
 					}
 

diff --git a/packages/editor-ui/src/utils/mappingUtils.ts b/packages/editor-ui/src/utils/mappingUtils.ts
@@ -97,7 +97,9 @@ export function getMappedResult(
 	} else if (typeof prevValue === 'string' && isExpression(prevValue) && prevValue.length > 1) {
 		return `${prevValue} ${newParamValue}`;
 	} else if (prevValue && ['string', 'json'].includes(parameter.type)) {
-		return prevValue === '=' ? `=${newParamValue}` : `=${prevValue} ${newParamValue}`;
+		return prevValue === '=' || typeof prevValue === 'object'
+			? `=${newParamValue}`
+			: `=${prevValue} ${newParamValue}`;
 	}
 
 	return `=${newParamValue}`;