fix(core): Fix the type for InstalledNodes.latestVersion (no-changelo…

…g) (#10782)
n8n-io · Sep 12, 2024 · 7d6ec65 · 7d6ec65
1 parent 8496adb
commit 7d6ec65
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/packages/cli/src/databases/entities/installed-nodes.ts b/packages/cli/src/databases/entities/installed-nodes.ts
@@ -10,7 +10,7 @@ export class InstalledNodes {
 	type: string;
 
 	@Column()
-	latestVersion: string;
+	latestVersion: number;
 
 	@ManyToOne('InstalledPackages', 'installedNodes')
 	@JoinColumn({ name: 'package', referencedColumnName: 'packageName' })

diff --git a/packages/cli/src/databases/repositories/installed-packages.repository.ts b/packages/cli/src/databases/repositories/installed-packages.repository.ts
@@ -35,7 +35,7 @@ export class InstalledPackagesRepository extends Repository<InstalledPackages> {
 				const installedNode = this.installedNodesRepository.create({
 					name: nodeTypes[loadedNode.name].type.description.displayName,
 					type: loadedNode.name,
-					latestVersion: loadedNode.version.toString(),
+					latestVersion: loadedNode.version,
 					package: { packageName },
 				});
 

diff --git a/packages/cli/test/integration/security-audit/utils.ts b/packages/cli/test/integration/security-audit/utils.ts
@@ -104,7 +104,7 @@ export const MOCK_PACKAGE: InstalledPackages[] = [
 			{
 				name: 'My Test Node',
 				type: 'myTestNode',
-				latestVersion: '1',
+				latestVersion: 1,
 			} as InstalledNodes,
 		],
 	},

diff --git a/packages/cli/test/integration/shared/utils/community-nodes.ts b/packages/cli/test/integration/shared/utils/community-nodes.ts
@@ -22,7 +22,7 @@ export const mockNode = (packageName: string) => {
 	return Container.get(InstalledNodesRepository).create({
 		name: nodeName,
 		type: nodeName,
-		latestVersion: COMMUNITY_NODE_VERSION.CURRENT.toString(),
+		latestVersion: COMMUNITY_NODE_VERSION.CURRENT,
 		package: { packageName },
 	});
 };

diff --git a/packages/workflow/src/Interfaces.ts b/packages/workflow/src/Interfaces.ts
@@ -2447,7 +2447,7 @@ export type PublicInstalledPackage = {
 export type PublicInstalledNode = {
 	name: string;
 	type: string;
-	latestVersion: string;
+	latestVersion: number;
 	package: PublicInstalledPackage;
 };