Skip to content

Commit

Permalink
refactor(core): Instrument multi-main to report failures to renew lea…
Browse files Browse the repository at this point in the history
…se (#7970)

## Summary
Instrument multi-main to report failures to renew the lease

https://linear.app/n8n/issue/PAY-1105
...

#### How to test the change:
1. ...


## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers

...


## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
  • Loading branch information
ivov authored Dec 11, 2023
1 parent 148bc1d commit 76ab411
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Service } from 'typedi';
import { TIME } from '@/constants';
import { SingleMainSetup } from '@/services/orchestration/main/SingleMainSetup';
import { getRedisPrefix } from '@/services/redis/RedisServiceHelper';
import { ErrorReporterProxy as EventReporter } from 'n8n-workflow';

@Service()
export class MultiMainSetup extends SingleMainSetup {
Expand Down Expand Up @@ -79,6 +80,10 @@ export class MultiMainSetup extends SingleMainSetup {
if (config.getEnv('multiMainSetup.instanceType') === 'leader') {
this.emit('leadershipChange', leaderId); // stop triggers, pruning, etc.

EventReporter.report('[Multi-main setup] Leader failed to renew leader key', {
level: 'info',
});

config.set('multiMainSetup.instanceType', 'follower');
}

Expand Down
2 changes: 2 additions & 0 deletions packages/workflow/src/ErrorReporterProxy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,7 @@ export const error = (e: unknown, options?: ReportingOptions) => {
if (toReport) instance.report(toReport, options);
};

export const report = error;

export const warn = (warning: Error | string, options?: ReportingOptions) =>
error(warning, { level: 'warning', ...options });
2 changes: 1 addition & 1 deletion packages/workflow/src/errors/application.error.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import callsites from 'callsites';
import type { Event } from '@sentry/node';

type Level = 'warning' | 'error' | 'fatal';
type Level = 'warning' | 'error' | 'fatal' | 'info';

export type ReportingOptions = {
level?: Level;
Expand Down

0 comments on commit 76ab411

Please sign in to comment.