refactor(core): Delete unused code, and fix typings in tests (no-chan…

…gelog)
n8n-io · Dec 22, 2023 · 755a511 · 755a511
1 parent baee47a
commit 755a511
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 202 deletions.
diff --git a/packages/cli/src/WorkflowCredentials.ts b/packages/cli/src/WorkflowCredentials.ts
diff --git a/packages/cli/test/integration/credentials.controller.test.ts b/packages/cli/test/integration/credentials.controller.test.ts
@@ -1,4 +1,4 @@
-import type { Credentials } from '@/requests';
+import type { ListQuery } from '@/requests';
 import type { User } from '@db/entities/User';
 import * as testDb from './shared/testDb';
 import { setupTestServer } from './shared/utils/';
@@ -21,7 +21,7 @@ beforeEach(async () => {
 	member = await createMember();
 });
 
-type GetAllResponse = { body: { data: Credentials.WithOwnedByAndSharedWith[] } };
+type GetAllResponse = { body: { data: ListQuery.Credentials.WithOwnedByAndSharedWith[] } };
 
 describe('GET /credentials', () => {
 	describe('should return', () => {
@@ -278,7 +278,7 @@ describe('GET /credentials', () => {
 	});
 });
 
-function validateCredential(credential: Credentials.WithOwnedByAndSharedWith) {
+function validateCredential(credential: ListQuery.Credentials.WithOwnedByAndSharedWith) {
 	const { name, type, nodesAccess, sharedWith, ownedBy } = credential;
 
 	expect(typeof name).toBe('string');

diff --git a/packages/cli/test/integration/database/repositories/execution.repository.test.ts b/packages/cli/test/integration/database/repositories/execution.repository.test.ts
@@ -24,6 +24,7 @@ describe('ExecutionRepository', () => {
 			const executionId = await executionRepo.createNewExecution({
 				workflowId: workflow.id,
 				data: {
+					//@ts-expect-error This is not needed for tests
 					resultData: {},
 				},
 				workflowData: workflow,

diff --git a/packages/cli/test/unit/CredentialsHelper.test.ts b/packages/cli/test/unit/CredentialsHelper.test.ts
@@ -271,6 +271,7 @@ describe('CredentialsHelper', () => {
 
 		for (const testData of tests) {
 			test(testData.description, async () => {
+				//@ts-expect-error `loadedCredentials` is a getter and we are replacing it here with a property
 				mockNodesAndCredentials.loadedCredentials = {
 					[testData.input.credentialType.name]: {
 						type: testData.input.credentialType,

diff --git a/packages/cli/test/unit/InternalHooks.test.ts b/packages/cli/test/unit/InternalHooks.test.ts
@@ -41,6 +41,7 @@ describe('InternalHooks', () => {
 			licensePlanName,
 			licenseTenantId,
 			binary_data_s3: false,
+			multi_main_setup_enabled: false,
 		};
 
 		const parameters = {

diff --git a/packages/cli/test/unit/Telemetry.test.ts b/packages/cli/test/unit/Telemetry.test.ts
@@ -48,7 +48,7 @@ describe('Telemetry', () => {
 		const postHog = new PostHogClient(instanceSettings);
 		await postHog.init();
 
-		telemetry = new Telemetry(mock(), postHog, mock(), instanceSettings);
+		telemetry = new Telemetry(mock(), postHog, mock(), instanceSettings, mock());
 		(telemetry as any).rudderStack = mockRudderStack;
 	});
 

diff --git a/packages/cli/test/unit/WorkflowCredentials.test.ts b/packages/cli/test/unit/WorkflowCredentials.test.ts