fix: Prevent displaying an endless timer in the execution list for fi…

…nished executions (#6137)
n8n-io · Apr 28, 2023 · 701105e · 701105e
1 parent 90a62cc
commit 701105e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/packages/editor-ui/src/components/ExecutionsList.vue b/packages/editor-ui/src/components/ExecutionsList.vue
@@ -800,16 +800,16 @@ export default mixins(externalHooks, genericHelpers, executionHelpers, showMessa
 				path = 'executionsList.statusWaiting';
 			} else if (status === 'canceled') {
 				path = 'executionsList.statusCanceled';
-			} else if (status === 'crashed') {
-				path = 'executionsList.statusText';
+			} else if (['crashed', 'failed', 'success'].includes(status)) {
+				if (!entry.stoppedAt) {
+					path = 'executionsList.statusTextWithoutTime';
+				} else {
+					path = 'executionsList.statusText';
+				}
 			} else if (status === 'new') {
 				path = 'executionsList.statusRunning';
 			} else if (status === 'running') {
 				path = 'executionsList.statusRunning';
-			} else if (status === 'success') {
-				path = 'executionsList.statusText';
-			} else if (status === 'failed') {
-				path = 'executionsList.statusText';
 			} else {
 				path = 'executionsList.statusUnknown';
 			}

diff --git a/packages/editor-ui/src/plugins/i18n/locales/en.json b/packages/editor-ui/src/plugins/i18n/locales/en.json
@@ -510,6 +510,7 @@
 	"executionsList.status": "Status",
 	"executionsList.statusCanceled": "Canceled",
 	"executionsList.statusText": "{status} in {time}",
+	"executionsList.statusTextWithoutTime": "{status}",
 	"executionsList.statusRunning": "{status} for {time}",
 	"executionsList.statusWaiting": "{status} until {time}",
 	"executionsList.statusUnknown": "Could not complete",