fix(core): Better errors for common status codes fix

n8n-io · May 3, 2023 · 700cc39 · 700cc39
1 parent 570790e
commit 700cc39
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/workflow/src/NodeErrors.ts b/packages/workflow/src/NodeErrors.ts
@@ -316,12 +316,17 @@ export class NodeApiError extends NodeError {
 				(error?.reason as IDataObject)?.description) as string;
 		}
 
-		if (!httpCode && !message && error.status === 'rejected') {
+		if (
+			!httpCode &&
+			!message &&
+			this.message &&
+			this.message.toUpperCase().includes('ECONNREFUSED')
+		) {
 			httpCode = 'ECONNREFUSED';
 
 			const originalMessage = this.message;
-			if (!description && originalMessage) {
-				this.description = `${originalMessage} ${this.description ?? ''}`;
+			if (!description) {
+				this.description = `${originalMessage}; ${this.description ?? ''}`;
 			}
 		}
 

diff --git a/packages/workflow/test/NodeErrors.test.ts b/packages/workflow/test/NodeErrors.test.ts
@@ -61,7 +61,6 @@ describe('NodeErrors tests', () => {
 
 	it('should return default message for ECONNREFUSED', () => {
 		const nodeApiError = new NodeApiError(node, {
-			status: 'rejected',
 			message: 'ECONNREFUSED',
 		});