fix: Enable Assistant on other credential views (#10931)

n8n-io · Sep 23, 2024 · 557db9c · 557db9c
1 parent eae4e30
commit 557db9c
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/packages/editor-ui/src/stores/__tests__/assistant.store.test.ts b/packages/editor-ui/src/stores/__tests__/assistant.store.test.ts
@@ -13,7 +13,7 @@ import { useSettingsStore } from '@/stores/settings.store';
 import { defaultSettings } from '../../__tests__/defaults';
 import { merge } from 'lodash-es';
 import { DEFAULT_POSTHOG_SETTINGS } from './posthog.test';
-import { AI_ASSISTANT_EXPERIMENT } from '@/constants';
+import { AI_ASSISTANT_EXPERIMENT, VIEWS } from '@/constants';
 import { reactive } from 'vue';
 import * as chatAPI from '@/api/assistant';
 import * as telemetryModule from '@/composables/useTelemetry';
@@ -41,12 +41,13 @@ const setAssistantEnabled = (enabled: boolean) => {
 	);
 };
 
+let currentRouteName = ENABLED_VIEWS[0];
 vi.mock('vue-router', () => ({
 	useRoute: vi.fn(() =>
 		reactive({
 			path: '/',
 			params: {},
-			name: ENABLED_VIEWS[0],
+			name: currentRouteName,
 		}),
 	),
 	useRouter: vi.fn(),
@@ -309,6 +310,30 @@ describe('AI Assistant store', () => {
 		expect(assistantStore.canShowAssistantButtonsOnCanvas).toBe(true);
 	});
 
+	it('should not show assistant if on a settings page', () => {
+		currentRouteName = VIEWS.SSO_SETTINGS;
+		const assistantStore = useAssistantStore();
+
+		setAssistantEnabled(true);
+		mockPostHogVariant('variant');
+		expect(assistantStore.isAssistantEnabled).toBe(true);
+		expect(assistantStore.canShowAssistant).toBe(false);
+		expect(assistantStore.canShowAssistantButtonsOnCanvas).toBe(false);
+	});
+
+	[VIEWS.PROJECTS_CREDENTIALS, VIEWS.TEMPLATE_SETUP, VIEWS.CREDENTIALS].forEach((view) => {
+		it(`should show assistant if on ${view} page`, () => {
+			currentRouteName = VIEWS.PROJECTS_CREDENTIALS;
+			const assistantStore = useAssistantStore();
+
+			setAssistantEnabled(true);
+			mockPostHogVariant('variant');
+			expect(assistantStore.isAssistantEnabled).toBe(true);
+			expect(assistantStore.canShowAssistant).toBe(true);
+			expect(assistantStore.canShowAssistantButtonsOnCanvas).toBe(false);
+		});
+	});
+
 	it('should initialize assistant chat session on node error', async () => {
 		const context: ChatRequest.ErrorContext = {
 			error: {

diff --git a/packages/editor-ui/src/stores/assistant.store.ts b/packages/editor-ui/src/stores/assistant.store.ts
@@ -46,6 +46,10 @@ export const ENABLED_VIEWS = [
 	VIEWS.EXECUTION_PREVIEW,
 	VIEWS.WORKFLOWS,
 	VIEWS.CREDENTIALS,
+	VIEWS.PROJECTS_CREDENTIALS,
+	VIEWS.PROJECTS_WORKFLOWS,
+	VIEWS.PROJECT_SETTINGS,
+	VIEWS.TEMPLATE_SETUP,
 ];
 const READABLE_TYPES = ['code-diff', 'text', 'block'];