fix(Google Drive Node): Fix issue preventing upload / update working …

…in some configurations (#8417)
n8n-io · Jan 23, 2024 · 4b3ea81 · 4b3ea81
1 parent a8b4684
commit 4b3ea81
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 10 deletions.
diff --git a/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/copy.test.ts b/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/copy.test.ts
@@ -26,7 +26,7 @@ describe('test GoogleDriveV2: file copy', () => {
 		jest.unmock('../../../../v2/transport');
 	});
 
-	it('shuold be called with', async () => {
+	it('should be called with', async () => {
 		const nodeParameters = {
 			operation: 'copy',
 			fileId: {

diff --git a/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/createFromText.test.ts b/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/createFromText.test.ts
@@ -26,7 +26,7 @@ describe('test GoogleDriveV2: file createFromText', () => {
 		jest.unmock('../../../../v2/transport');
 	});
 
-	it('shuold be called with', async () => {
+	it('should be called with', async () => {
 		const nodeParameters = {
 			operation: 'createFromText',
 			content: 'hello drive!',

diff --git a/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/deleteFile.test.ts b/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/deleteFile.test.ts
@@ -26,7 +26,7 @@ describe('test GoogleDriveV2: file deleteFile', () => {
 		jest.unmock('../../../../v2/transport');
 	});
 
-	it('shuold be called with', async () => {
+	it('should be called with', async () => {
 		const nodeParameters = {
 			operation: 'deleteFile',
 			fileId: {

diff --git a/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/move.test.ts b/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/move.test.ts
@@ -31,7 +31,7 @@ describe('test GoogleDriveV2: file move', () => {
 		jest.unmock('../../../../v2/transport');
 	});
 
-	it('shuold be called with', async () => {
+	it('should be called with', async () => {
 		const nodeParameters = {
 			operation: 'move',
 			fileId: {

diff --git a/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/share.test.ts b/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/share.test.ts
@@ -26,7 +26,7 @@ describe('test GoogleDriveV2: file share', () => {
 		jest.unmock('../../../../v2/transport');
 	});
 
-	it('shuold be called with', async () => {
+	it('should be called with', async () => {
 		const nodeParameters = {
 			operation: 'share',
 			fileId: {

diff --git a/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/update.test.ts b/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/update.test.ts
@@ -26,7 +26,7 @@ describe('test GoogleDriveV2: file update', () => {
 		jest.unmock('../../../../v2/transport');
 	});
 
-	it('shuold be called with', async () => {
+	it('should be called with', async () => {
 		const nodeParameters = {
 			operation: 'update',
 			fileId: {

diff --git a/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/upload.test.ts b/packages/nodes-base/nodes/Google/Drive/test/v2/node/file/upload.test.ts
@@ -48,7 +48,7 @@ describe('test GoogleDriveV2: file upload', () => {
 		jest.unmock('../../../../v2/helpers/utils');
 	});
 
-	it('shuold be called with', async () => {
+	it('should be called with', async () => {
 		const nodeParameters = {
 			name: 'newFile.txt',
 			folderId: {
@@ -75,7 +75,7 @@ describe('test GoogleDriveV2: file upload', () => {
 			undefined,
 			{ uploadType: 'resumable' },
 			undefined,
-			{ resolveWithFullResponse: true },
+			{ returnFullResponse: true },
 		);
 		expect(transport.googleApiRequest).toHaveBeenCalledWith(
 			'PATCH',

diff --git a/packages/nodes-base/nodes/Google/Drive/v2/actions/file/update.operation.ts b/packages/nodes-base/nodes/Google/Drive/v2/actions/file/update.operation.ts
@@ -203,7 +203,7 @@ export async function execute(this: IExecuteFunctions, i: number): Promise<INode
 				{ uploadType: 'resumable' },
 				undefined,
 				{
-					resolveWithFullResponse: true,
+					returnFullResponse: true,
 				},
 			);
 			const uploadUrl = resumableUpload.headers.location;

diff --git a/packages/nodes-base/nodes/Google/Drive/v2/actions/file/upload.operation.ts b/packages/nodes-base/nodes/Google/Drive/v2/actions/file/upload.operation.ts
@@ -123,9 +123,10 @@ export async function execute(this: IExecuteFunctions, i: number): Promise<INode
 			{ uploadType: 'resumable' },
 			undefined,
 			{
-				resolveWithFullResponse: true,
+				returnFullResponse: true,
 			},
 		);
+
 		const uploadUrl = resumableUpload.headers.location;
 
 		let offset = 0;