Skip to content

Commit

Permalink
fix(core): Don't report executions that have been paused as failed to…
Browse files Browse the repository at this point in the history
… rudderstack and log streams (#8501)
  • Loading branch information
despairblue authored Jan 31, 2024
1 parent dac511b commit 39e8754
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions packages/cli/src/InternalHooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,11 @@ export class InternalHooks {
return;
}

if (runData?.status === 'waiting') {
// No need to send telemetry or logs when the workflow hasn't finished yet.
return;
}

const promises = [];

const telemetryProperties: IExecutionTrackProperties = {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/WorkflowExecuteAdditionalData.ts
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ function hookFunctionsSaveWorker(): IWorkflowExecuteHooks {

const workflowStatusFinal = determineFinalExecutionStatus(fullRunData);

if (workflowStatusFinal !== 'success') {
if (workflowStatusFinal !== 'success' && workflowStatusFinal !== 'waiting') {
executeErrorWorkflow(
this.workflowData,
fullRunData,
Expand Down

0 comments on commit 39e8754

Please sign in to comment.