Skip to content

Commit

Permalink
fix(core): Ensure status on Axios errors is available to the BE (#9015
Browse files Browse the repository at this point in the history
)
  • Loading branch information
ivov authored and despairblue committed Apr 4, 2024
1 parent 8cbe2bf commit 39002b0
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
5 changes: 5 additions & 0 deletions packages/core/src/NodeExecuteFunctions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,11 @@ export async function proxyRequestToAxios(
error.message = `${response.status as number} - ${JSON.stringify(responseData)}`;
throw Object.assign(error, {
statusCode: response.status,
/**
* Axios adds `status` when serializing, causing `status` to be available only to the client.
* Hence we add it explicitly to allow the backend to use it when resolving expressions.
*/
status: response.status,
error: responseData,
response: pick(response, ['headers', 'status', 'statusText']),
});
Expand Down
10 changes: 10 additions & 0 deletions packages/core/test/NodeExecuteFunctions.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,16 @@ describe('NodeExecuteFunctions', () => {
hooks.executeHookFunctions.mockClear();
});

test('should rethrow an error with `status` property', async () => {
nock(baseUrl).get('/test').reply(400);

try {
await proxyRequestToAxios(workflow, additionalData, node, `${baseUrl}/test`);
} catch (error) {
expect(error.status).toEqual(400);
}
});

test('should not throw if the response status is 200', async () => {
nock(baseUrl).get('/test').reply(200);
await proxyRequestToAxios(workflow, additionalData, node, `${baseUrl}/test`);
Expand Down

0 comments on commit 39002b0

Please sign in to comment.