ci: Upgrade eslint, prettier, typescript, and some other dev tooling …

…(no-changelog) (#8895)

Co-authored-by: Iván Ovejero <[email protected]>

package.json

@@ -83,12 +83,11 @@
       "axios": "1.6.7",
       "chokidar": "3.5.2",
       "formidable": "3.5.1",
-      "ip": "2.0.1",
-      "prettier": "^3.1.0",
+      "prettier": "^3.2.5",
       "semver": "^7.5.4",
-      "tslib": "^2.6.1",
+      "tslib": "^2.6.2",
       "tsconfig-paths": "^4.2.0",
-      "typescript": "^5.3.0"
+      "typescript": "^5.4.2"
     },
     "patchedDependencies": {
       "[email protected]": "patches/[email protected]",

packages/@n8n/nodes-langchain/nodes/llms/LMChatOpenAi/LmChatOpenAi.node.ts

@@ -250,7 +250,7 @@ export class LmChatOpenAi implements INodeType {
 			modelKwargs: options.responseFormat
 				? {
 						response_format: { type: options.responseFormat },
-				  }
+					}
 				: undefined,
 		});
 

packages/@n8n_io/eslint-config/package.json

@@ -3,23 +3,23 @@
   "private": true,
   "version": "0.0.1",
   "devDependencies": {
-    "@types/eslint": "^8.44.7",
-    "@typescript-eslint/eslint-plugin": "^6.12.0",
-    "@typescript-eslint/parser": "^6.12.0",
-    "@vue/eslint-config-prettier": "^8.0.0",
-    "@vue/eslint-config-typescript": "^12.0.0",
-    "eslint": "^8.54.0",
-    "eslint-config-airbnb-typescript": "^17.1.0",
-    "eslint-config-prettier": "^9.0.0",
+    "@types/eslint": "^8.56.5",
+    "@typescript-eslint/eslint-plugin": "^7.2.0",
+    "@typescript-eslint/parser": "^7.2.0",
+    "@vue/eslint-config-prettier": "^9.0.0",
+    "@vue/eslint-config-typescript": "^13.0.0",
+    "eslint": "^8.57.0",
+    "eslint-config-airbnb-typescript": "^18.0.0",
+    "eslint-config-prettier": "^9.1.0",
     "eslint-import-resolver-typescript": "^3.6.1",
-    "eslint-plugin-import": "^2.29.0",
+    "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-lodash": "^7.4.0",
     "eslint-plugin-n8n-local-rules": "^1.0.0",
-    "eslint-plugin-prettier": "^5.0.1",
-    "eslint-plugin-unicorn": "^49.0.0",
-    "eslint-plugin-unused-imports": "^3.0.0",
-    "eslint-plugin-vue": "^9.18.1",
-    "vue-eslint-parser": "^9.3.2"
+    "eslint-plugin-prettier": "^5.1.3",
+    "eslint-plugin-unicorn": "^51.0.1",
+    "eslint-plugin-unused-imports": "^3.1.0",
+    "eslint-plugin-vue": "^9.23.0",
+    "vue-eslint-parser": "^9.4.2"
   },
   "scripts": {
     "clean": "rimraf .turbo",

packages/cli/src/InternalHooks.ts

@@ -488,7 +488,7 @@ export class InternalHooks {
 				? this.eventBus.sendWorkflowEvent({
 						eventName: 'n8n.workflow.success',
 						payload: sharedEventPayload,
-				  })
+					})
 				: this.eventBus.sendWorkflowEvent({
 						eventName: 'n8n.workflow.failed',
 						payload: {
@@ -498,7 +498,7 @@ export class InternalHooks {
 							errorNodeId: telemetryProperties.error_node_id?.toString(),
 							errorMessage: telemetryProperties.error_message?.toString(),
 						},
-				  }),
+					}),
 		);
 
 		void Promise.all([...promises, this.telemetry.trackWorkflowExecution(telemetryProperties)]);

packages/cli/src/LoadNodesAndCredentials.ts

@@ -133,7 +133,7 @@ export class LoadNodesAndCredentials {
 			: [
 					...(await glob('n8n-nodes-*', globOptions)),
 					...(await glob('@*/n8n-nodes-*', { ...globOptions, deep: 2 })),
-			  ];
+				];
 
 		for (const packagePath of installedPackagePaths) {
 			try {

packages/cli/src/TestWebhooks.ts

@@ -108,7 +108,7 @@ export class TestWebhooks implements IWebhookManager {
 				const executionMode = 'manual';
 				const executionId = await WebhookHelpers.executeWebhook(
 					workflow,
-					webhook!,
+					webhook,
 					workflowEntity,
 					workflowStartNode,
 					executionMode,

packages/cli/src/WebhookHelpers.ts

@@ -828,7 +828,7 @@ export async function executeWebhook(
 				: new ApplicationError('There was a problem executing the workflow', {
 						level: 'warning',
 						cause: e,
-				  });
+					});
 		if (didSendResponse) throw error;
 		responseCallback(error, {});
 		return;

packages/cli/src/config/types.ts

@@ -19,7 +19,7 @@ type GetPathSegments<Traversable, Filter> = Traversable extends Filter
 	? []
 	: {
 			[K in ValidKeys<Traversable>]: [K, ...GetPathSegments<Traversable[K], Filter>];
-	  }[ValidKeys<Traversable>];
+		}[ValidKeys<Traversable>];
 
 /**
  * Transform a union of string arrays (path segments) into a union of strings (dotted paths).
@@ -31,12 +31,12 @@ type GetPathSegments<Traversable, Filter> = Traversable extends Filter
 type JoinByDotting<T extends string[]> = T extends [infer F]
 	? F
 	: T extends [infer F, ...infer R]
-	  ? F extends string
+		? F extends string
 			? R extends string[]
 				? `${F}.${JoinByDotting<R>}`
 				: never
 			: never
-	  : string;
+		: string;
 
 type ToDottedPath<T> = JoinByDotting<RemoveExcess<T>>;
 
@@ -64,14 +64,14 @@ type ConfigOptionPath =
 type ToReturnType<T extends ConfigOptionPath> = T extends NumericPath
 	? number
 	: T extends BooleanPath
-	  ? boolean
-	  : T extends StringLiteralArrayPath
-	    ? StringLiteralMap[T]
-	    : T extends keyof ExceptionPaths
-	      ? ExceptionPaths[T]
-	      : T extends StringPath
-	        ? string
-	        : unknown;
+		? boolean
+		: T extends StringLiteralArrayPath
+			? StringLiteralMap[T]
+			: T extends keyof ExceptionPaths
+				? ExceptionPaths[T]
+				: T extends StringPath
+					? string
+					: unknown;
 
 type ExceptionPaths = {
 	'queue.bull.redis': object;
@@ -86,11 +86,12 @@ type ExceptionPaths = {
 //        string literals map
 // -----------------------------------
 
-type GetPathSegmentsWithUnions<T> = T extends ReadonlyArray<infer C>
-	? [C]
-	: {
-			[K in ValidKeys<T>]: [K, ...GetPathSegmentsWithUnions<T[K]>];
-	  }[ValidKeys<T>];
+type GetPathSegmentsWithUnions<T> =
+	T extends ReadonlyArray<infer C>
+		? [C]
+		: {
+				[K in ValidKeys<T>]: [K, ...GetPathSegmentsWithUnions<T[K]>];
+			}[ValidKeys<T>];
 
 type ToPathUnionPair<T extends string[]> = T extends [...infer Path, infer Union]
 	? Path extends string[]

packages/cli/src/credentials/credentials.controller.ts

@@ -358,7 +358,7 @@ export class CredentialsController {
 			);
 
 			if (newShareeIds.length) {
-				await this.enterpriseCredentialsService.share(trx, credential!, newShareeIds);
+				await this.enterpriseCredentialsService.share(trx, credential, newShareeIds);
 			}
 		});
 

packages/cli/src/databases/migrations/common/1674509946020-CreateLdapEntities.ts

@@ -29,15 +29,15 @@ export class CreateLdapEntities1674509946020 implements ReversibleMigration {
 			dbType === 'sqlite'
 				? 'INTEGER PRIMARY KEY AUTOINCREMENT'
 				: dbType === 'postgresdb'
-				  ? 'SERIAL NOT NULL PRIMARY KEY'
-				  : 'INTEGER NOT NULL AUTO_INCREMENT';
+					? 'SERIAL NOT NULL PRIMARY KEY'
+					: 'INTEGER NOT NULL AUTO_INCREMENT';
 
 		const timestampColumn =
 			dbType === 'sqlite'
 				? 'DATETIME NOT NULL'
 				: dbType === 'postgresdb'
-				  ? 'TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP'
-				  : 'DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP';
+					? 'TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP'
+					: 'DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP';
 
 		await runQuery(
 			`CREATE TABLE IF NOT EXISTS ${escape.tableName('auth_provider_sync_history')} (

packages/cli/src/databases/repositories/installedPackages.repository.ts

@@ -31,7 +31,7 @@ export class InstalledPackagesRepository extends Repository<InstalledPackages> {
 
 			installedPackage.installedNodes = [];
 
-			return loadedNodes.map(async (loadedNode) => {
+			for (const loadedNode of loadedNodes) {
 				const installedNode = this.installedNodesRepository.create({
 					name: nodeTypes[loadedNode.name].type.description.displayName,
 					type: loadedNode.name,
@@ -41,8 +41,8 @@ export class InstalledPackagesRepository extends Repository<InstalledPackages> {
 
 				installedPackage.installedNodes.push(installedNode);
 
-				return await manager.save(installedNode);
-			});
+				await manager.save(installedNode);
+			}
 		});
 
 		return installedPackage!;

packages/cli/src/databases/repositories/workflow.repository.ts

@@ -136,7 +136,7 @@ export class WorkflowRepository extends Repository<WorkflowEntity> {
 					updatedAt: true,
 					versionId: true,
 					shared: { userId: true, role: true },
-			  };
+				};
 
 		delete select?.ownedBy; // remove non-entity field, handled after query
 

packages/cli/src/eventbus/MessageEventBusDestination/Helpers.ee.ts

@@ -26,7 +26,7 @@ export function getLabelsForEvent(event: EventMessageTypes): Record<string, stri
 							credential_type: getLabelValueForCredential(
 								event.payload.credentialType ?? 'unknown',
 							),
-					  }
+						}
 					: {};
 			}
 

packages/cli/src/services/credentials-tester.service.ts

@@ -127,11 +127,11 @@ export class CredentialsTester {
 								? {
 										status: 'OK',
 										message: OAUTH2_CREDENTIAL_TEST_SUCCEEDED,
-								  }
+									}
 								: {
 										status: 'Error',
 										message: OAUTH2_CREDENTIAL_TEST_FAILED,
-								  };
+									};
 						};
 					}
 

packages/cli/src/services/orchestration/worker/handleCommandMessageWorker.ts

@@ -49,13 +49,12 @@ export function getWorkerCommandReceivedHandler(options: WorkerCommandReceivedHa
 								arch: os.arch(),
 								platform: os.platform(),
 								hostname: os.hostname(),
-								interfaces: Object.values(os.networkInterfaces()).flatMap(
-									(interfaces) =>
-										(interfaces ?? [])?.map((net) => ({
-											family: net.family,
-											address: net.address,
-											internal: net.internal,
-										})),
+								interfaces: Object.values(os.networkInterfaces()).flatMap((interfaces) =>
+									(interfaces ?? [])?.map((net) => ({
+										family: net.family,
+										address: net.address,
+										internal: net.internal,
+									})),
 								),
 								version: N8N_VERSION,
 							},

packages/cli/src/workflows/workflow.service.ts

@@ -51,7 +51,7 @@ export class WorkflowService {
 			? {
 					workflows: workflows.map((w) => this.ownershipService.addOwnedByAndSharedWith(w)),
 					count,
-			  }
+				}
 			: { workflows, count };
 	}
 

packages/cli/src/workflows/workflows.controller.ts

@@ -393,7 +393,7 @@ export class WorkflowsController {
 
 			if (newShareeIds.length) {
 				const users = await this.userRepository.getByIds(trx, newShareeIds);
-				await this.sharedWorkflowRepository.share(trx, workflow!, users);
+				await this.sharedWorkflowRepository.share(trx, workflow, users);
 			}
 		});
 

packages/cli/test/integration/workflowHistory.api.test.ts

@@ -66,7 +66,7 @@ describe('GET /workflow-history/:workflowId', () => {
 				),
 		);
 
-		const last = versions.sort((a, b) => b.createdAt.valueOf() - a.createdAt.valueOf())[0]! as any;
+		const last = versions.sort((a, b) => b.createdAt.valueOf() - a.createdAt.valueOf())[0] as any;
 		delete last.nodes;
 		delete last.connections;
 
@@ -95,7 +95,7 @@ describe('GET /workflow-history/:workflowId', () => {
 			new Array(10).fill(undefined).map(async (_) => await createWorkflowHistoryItem(workflow2.id)),
 		);
 
-		const last = versions.sort((a, b) => b.createdAt.valueOf() - a.createdAt.valueOf())[0]! as any;
+		const last = versions.sort((a, b) => b.createdAt.valueOf() - a.createdAt.valueOf())[0] as any;
 		delete last.nodes;
 		delete last.connections;
 
@@ -119,7 +119,7 @@ describe('GET /workflow-history/:workflowId', () => {
 				),
 		);
 
-		const last = versions.sort((a, b) => b.createdAt.valueOf() - a.createdAt.valueOf())[0]! as any;
+		const last = versions.sort((a, b) => b.createdAt.valueOf() - a.createdAt.valueOf())[0] as any;
 		delete last.nodes;
 		delete last.connections;
 
@@ -143,7 +143,7 @@ describe('GET /workflow-history/:workflowId', () => {
 				),
 		);
 
-		const last = versions.sort((a, b) => b.createdAt.valueOf() - a.createdAt.valueOf())[5]! as any;
+		const last = versions.sort((a, b) => b.createdAt.valueOf() - a.createdAt.valueOf())[5] as any;
 		delete last.nodes;
 		delete last.connections;
 

packages/core/src/NodeExecuteFunctions.ts

@@ -810,7 +810,7 @@ export async function proxyRequestToAxios(
 					statusCode: response.status,
 					statusMessage: response.statusText,
 					request: response.request,
-			  }
+				}
 			: body;
 	} catch (error) {
 		const { config, response } = error;
@@ -1042,7 +1042,7 @@ export function assertBinaryData(
 	propertyName: string,
 	inputIndex: number,
 ): IBinaryData {
-	const binaryKeyData = inputData.main[inputIndex]![itemIndex]!.binary;
+	const binaryKeyData = inputData.main[inputIndex]![itemIndex].binary;
 	if (binaryKeyData === undefined) {
 		throw new NodeOperationError(
 			node,
@@ -1079,7 +1079,7 @@ export async function getBinaryDataBuffer(
 	propertyName: string,
 	inputIndex: number,
 ): Promise<Buffer> {
-	const binaryData = inputData.main[inputIndex]![itemIndex]!.binary![propertyName]!;
+	const binaryData = inputData.main[inputIndex]![itemIndex].binary![propertyName];
 	return await Container.get(BinaryDataService).getAsBuffer(binaryData);
 }
 
@@ -1940,7 +1940,7 @@ export function getAdditionalKeys(
 						getAll(): Record<string, string> {
 							return getAllWorkflowExecutionMetadata(runExecutionData);
 						},
-				  }
+					}
 				: undefined,
 		},
 		$vars: additionalData.variables,
@@ -3204,7 +3204,7 @@ const getFileSystemHelperFunctions = (node: INode): FileSystemHelperFunctions =>
 				? new NodeOperationError(node, error, {
 						message: `The file "${String(filePath)}" could not be accessed.`,
 						level: 'warning',
-				  })
+					})
 				: error;
 		}
 		if (isFilePathBlocked(filePath as string)) {

packages/core/src/WorkflowExecute.ts

@@ -1575,9 +1575,9 @@ export class WorkflowExecute {
 							// array as this shows that the parent nodes executed but they did not have any
 							// data to pass on.
 							const inputsWithData = this.runExecutionData
-								.executionData!.waitingExecution[nodeName][firstRunIndex].main.map((data, index) =>
-									data === null ? null : index,
-								)
+								.executionData!.waitingExecution[
+									nodeName
+								][firstRunIndex].main.map((data, index) => (data === null ? null : index))
 								.filter((data) => data !== null);
 
 							if (requiredInputs !== undefined) {

packages/design-system/src/components/N8nCheckbox/Checkbox.vue

@@ -6,7 +6,7 @@
 		:disabled="disabled"
 		:indeterminate="indeterminate"
 		:model-value="modelValue"
-		@update:modelValue="onUpdateModelValue"
+		@update:model-value="onUpdateModelValue"
 	>
 		<slot></slot>
 		<N8nInputLabel