Skip to content

Commit

Permalink
fix(FileMaker Node): Prevent erroring on zero fields loaded (#7955)
Browse files Browse the repository at this point in the history
## Summary
https://n8nio.sentry.io/issues/4703111361

...

#### How to test the change:
1. ...


## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers

...


## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
  • Loading branch information
ivov authored Dec 7, 2023
1 parent 9b877a9 commit 10ad386
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/nodes-base/nodes/FileMaker/FileMaker.node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,8 @@ export class FileMaker implements INodeType {

const fields = await getFields.call(this);

if (!Array.isArray(fields)) return [];

for (const field of fields) {
returnData.push({
name: field.name,
Expand Down

0 comments on commit 10ad386

Please sign in to comment.