Skip to content

Commit

Permalink
evaluate the final execution status, even when saving is disabled
Browse files Browse the repository at this point in the history
  • Loading branch information
netroy committed Nov 22, 2024
1 parent c191b75 commit 0d7017d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/cli/src/workflow-execute-additional-data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ function hookFunctionsSave(): IWorkflowExecuteHooks {
await restoreBinaryDataId(fullRunData, this.executionId, this.mode);

const isManualMode = this.mode === 'manual';
const executionStatus = determineFinalExecutionStatus(fullRunData);

try {
if (!isManualMode && isWorkflowIdValid(this.workflowData.id) && newStaticData) {
Expand Down Expand Up @@ -436,7 +437,6 @@ function hookFunctionsSave(): IWorkflowExecuteHooks {
return;
}

const executionStatus = determineFinalExecutionStatus(fullRunData);
const shouldNotSave =
(executionStatus === 'success' && !saveSettings.success) ||
(executionStatus !== 'success' && !saveSettings.error);
Expand Down

0 comments on commit 0d7017d

Please sign in to comment.