Add some comments about the tkmk00 stuff #594
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taggerung <[email protected]>
coco875
reviewed
Apr 4, 2024
| @@ -445,6 +461,7 @@ glabel func_80040AC8 | |||
| /* 0417B8 80040BB8 03E00008 */ jr $ra | |||
| /* 0417BC 80040BBC 00000000 */ nop | |||
|
|
|||
| # func_80040BC0 -> SetUpHuffmanTree | |||
MegaMech
requested changes
Apr 6, 2024
|
|
||
| Maybe tkmk00 wasn't compiled with IDO. Its explicit usage of registers rather than variables is something that IDO can't do (I think?) but GCC can. | ||
| Or mabybe its C++ code and that interacts with registers differently? | ||
| Or maybe its all hand written? |
There was a problem hiding this comment.
It's my understanding that this assembly was hand-written.
There was a problem hiding this comment.
The code was likely assembled using IDO, however the code is almost certainly hand-written given the bal, add, and sub, instructions which are not used by any known compiler.
|
Taking another look at this PR. Everyone whose looked at this func said it was hand-written. My only issue is the comment about it being possibly compiled. It's my understanding that there's no known compiler that outputs assembly like this. bal instead of jal for example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.