Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepl plugin fix: avoid unicode escape characters in the response containing non-ANSI characters #542

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

yurnov
Copy link
Contributor

@yurnov yurnov commented Feb 28, 2024

reason for this change is to get Unicode escape characters in the response containing non-ANSI characters

potential fix for issue #541

Fix tested on my side, works fine:

image

reason for this change is avoiding to get unicode escape characters in response for non-ANSI characters

potential fix for issue n3d1117#541
The main aim of this commit is preventing including .env file to image
during local docker build. As well added Dockerfile, docker-compose and
GitHub Actions that is not reuqurid in the Docker image
@yurnov yurnov force-pushed the deelp-unicode_escape-fix branch from b0f0ec8 to a631d26 Compare February 28, 2024 18:23
@yurnov yurnov changed the title deepl plugin fix: add "Accept-Encoding: utf-8" to header [WIP] deepl plugin fix: add "Accept-Encoding: utf-8" to header Feb 28, 2024
@yurnov
Copy link
Contributor Author

yurnov commented Feb 28, 2024

Just found that in some cases it doesn't work, will investigate

@yurnov yurnov changed the title [WIP] deepl plugin fix: add "Accept-Encoding: utf-8" to header deepl plugin fix: add "Accept-Encoding: utf-8" to header Feb 28, 2024
@yurnov
Copy link
Contributor Author

yurnov commented Feb 28, 2024

Fixed and retested, PR is ready to merge.

Besides the main fix for #541 this PR includes a .dockerignore file to avoid slipping .env file into image.

@yurnov yurnov changed the title deepl plugin fix: add "Accept-Encoding: utf-8" to header deepl plugin fix: avoid unicode escape characters in the response containing non-ANSI characters Mar 1, 2024
@yurnov yurnov mentioned this pull request Mar 3, 2024
@n3d1117
Copy link
Owner

n3d1117 commented Mar 11, 2024

Thanks @yurnov

@n3d1117 n3d1117 merged commit cae6f96 into n3d1117:main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants