Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iroh)!: make blobs::read_at more flexible #2756

Merged
merged 2 commits into from
Sep 30, 2024
Merged

feat(iroh)!: make blobs::read_at more flexible #2756

merged 2 commits into from
Sep 30, 2024

Commits on Sep 30, 2024

  1. feat(iroh): make blobs::read_at more flexible 

    Introduces `ReadAtLen` which allows to specify the behaviour of `read_at` more closely

- `All` - reads until the end (formerly `None`)
- `Exact(size)` - Reads exactly this many bytes (formerly `Some(size)`
- `AtMost(size)` - Reads at most this many bytes, but allows for a shorter response if not enough data is available

Closes #2738

## Breaking Changes

- `iroh::client::Blobs::read_at` and `read_at_to_bytes` now take `ReadAtLen` instead of `Option<usize>`
    @dignifiedquire
    dignifiedquire committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b2b9f4c View commit details
    Browse the repository at this point in the history

  2. fix codespell (ignore atmost)

    @Arqu
    Arqu committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    86ebceb View commit details
    Browse the repository at this point in the history