feat(iroh): Allow setting a custom quinn::TransportConfig
#2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
changed the title
quinn::TransportConfig]quinn::TransportConfig
flub
approved these changes
Sep 30, 2024
This reverts commit 0aba63e.
iroh/src/node/builder.rs
Outdated
| @@ -125,6 +125,7 @@ where | |||
| #[debug("callback")] | |||
| gc_done_callback: Option<Box<dyn Fn() + Send>>, | |||
| blob_events: EventSender, | |||
| transport_config: Option<quinn::TransportConfig>, | |||
There was a problem hiding this comment.
are we reexporting the TransportConfig from iroh-net? if so maybe use that as import?
dignifiedquire
approved these changes
Sep 30, 2024
|
closed in favor of #2760 due to ci configuration issues related to forks |
auto-merge was automatically disabled
September 30, 2024 13:56
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows setting a custom configuration in the Iroh Node
Breaking Changes
n/a
Notes & open questions
n/a
Change checklist
Tests if relevant.All breaking changes documented.