-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iroh-cli)!: realign cli commands with library #2522
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/netsim branch fix-update-cli-commands |
/netsim branch fix-update-cli-commands |
1 similar comment
/netsim branch fix-update-cli-commands |
|
felixgborrego
added a commit
to felixgborrego/iroh.computer
that referenced
this pull request
Sep 12, 2024
While reviewing your documentation and working with Iroh, I noticed a few minor discrepancies between the documentation and the actual CLI commands. These differences are likely due to changes introduced in this n0-computer/iroh#2522.
felixgborrego
added a commit
to felixgborrego/iroh.computer
that referenced
this pull request
Sep 12, 2024
While reviewing your documentation and working with Iroh, I noticed a few minor discrepancies between the documentation and the actual CLI commands. These differences are likely due to changes introduced in this n0-computer/iroh#2522.
dignifiedquire
pushed a commit
to n0-computer/iroh.computer
that referenced
this pull request
Sep 16, 2024
While reviewing your documentation and working with Iroh, I noticed a few minor discrepancies between the documentation and the actual CLI commands. These differences are likely due to changes introduced in this n0-computer/iroh#2522.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had quite a few missmatches between CLI and library naming, this aligns it.
Breaking Changes
author
->authors
blob
->blobs
doc
->docs
tag
->tags
new
->create
Notes & open questions
Change checklist