Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iroh-cli)!: realign cli commands with library #2522

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

dignifiedquire
Copy link
Contributor

@dignifiedquire dignifiedquire commented Jul 19, 2024

Description

We had quite a few missmatches between CLI and library naming, this aligns it.

Breaking Changes

  • cli:
    • author -> authors
    • blob -> blobs
    • doc -> docs
    • tag -> tags
    • new -> create

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dignifiedquire
Copy link
Contributor Author

/netsim branch fix-update-cli-commands

@dignifiedquire
Copy link
Contributor Author

/netsim branch fix-update-cli-commands

1 similar comment
@dignifiedquire
Copy link
Contributor Author

/netsim branch fix-update-cli-commands

Copy link

feat-align-cli.97e8d917578ddb418e27bac359bc0264a4b2c4be
Perf report:

test case throughput_gbps throughput_transfer
iroh_latency_20ms 1_to_1 0.92 2.40
iroh_latency_20ms 1_to_3 2.76 6.46
iroh_latency_20ms 1_to_5 3.62 5.71
iroh_latency_20ms 1_to_10 5.14 6.77
iroh_latency_20ms 2_to_2 1.98 4.79
iroh_latency_20ms 2_to_4 3.60 8.34
iroh_latency_20ms 2_to_6 4.84 8.79
iroh_latency_20ms 2_to_10 6.28 9.46
iroh 1_to_1 1.11 2.92
iroh 1_to_3 2.84 6.24
iroh 1_to_5 3.89 6.63
iroh 1_to_10 4.86 6.32
iroh 2_to_2 1.96 4.70
iroh 2_to_4 3.70 7.88
iroh 2_to_6 4.95 9.10
iroh 2_to_10 5.84 8.45
iroh_latency_200ms 1_to_1 1.10 2.81
iroh_latency_200ms 1_to_3 2.84 7.15
iroh_latency_200ms 1_to_5 3.73 6.27
iroh_latency_200ms 1_to_10 4.65 5.95
iroh_latency_200ms 2_to_2 1.92 4.36
iroh_latency_200ms 2_to_4 3.71 7.66
iroh_latency_200ms 2_to_6 4.99 9.11
iroh_latency_200ms 2_to_10 6.46 9.66

@divagant-martian divagant-martian added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit 4c11c58 Jul 22, 2024
32 checks passed
@dignifiedquire dignifiedquire deleted the feat-align-cli branch July 22, 2024 10:23
felixgborrego added a commit to felixgborrego/iroh.computer that referenced this pull request Sep 12, 2024
While reviewing your documentation and working with Iroh, I noticed a few minor discrepancies between the documentation and the actual CLI commands.
These differences are likely due to changes introduced in this n0-computer/iroh#2522.
felixgborrego added a commit to felixgborrego/iroh.computer that referenced this pull request Sep 12, 2024
While reviewing your documentation and working with Iroh, I noticed a few minor discrepancies between the documentation and the actual CLI commands.
These differences are likely due to changes introduced in this n0-computer/iroh#2522.
dignifiedquire pushed a commit to n0-computer/iroh.computer that referenced this pull request Sep 16, 2024
While reviewing your documentation and working with Iroh, I noticed a few minor discrepancies between the documentation and the actual CLI commands.
These differences are likely due to changes introduced in this n0-computer/iroh#2522.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants