refactor(iroh): make use of quic-rpc-derive macros to prettify the rpc declarations #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use git dependency
rklaehn
force-pushed
the
quic-rpc-derive-macros
branch
from
46a67ea
to
36b7ff7
Compare
rklaehn
force-pushed
the
quic-rpc-derive-macros
branch
from
271a308
to
fd5f67a
Compare
flub
approved these changes
Jul 16, 2024
rklaehn
force-pushed
the
quic-rpc-derive-macros
branch
from
ae38eb3
to
dc5fc06
Compare
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
…c declarations (#2508) ## Description Make use of quic-rpc-derive macros to make the rpc declarations nicer to read. With this, you can clearly see the kind of interaction and the response type for each rpc message type in one place. Under the hood, this does the exact same thing as before. ## Breaking Changes None ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [x] ~~Tests if relevant.~~ - [x] ~~All breaking changes documented.~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make use of quic-rpc-derive macros to make the rpc declarations nicer to read. With this, you can clearly see the kind of interaction and the response type for each rpc message type in one place. Under the hood, this does the exact same thing as before.
Breaking Changes
None
Notes & open questions
Change checklist
Tests if relevant.All breaking changes documented.