Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: protocol handlers #1833

Closed
wants to merge 4 commits into from
Closed

[WIP] feat: protocol handlers #1833

wants to merge 4 commits into from

Conversation

Frando
Copy link
Member

@Frando Frando commented Nov 23, 2023

Description

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

@Frando Frando force-pushed the feat/protocol-handlers branch from 3139423 to 1e0ea3e Compare November 24, 2023 12:04
@Frando
Copy link
Member Author

Frando commented Nov 24, 2023

This does not work out well this way. Instead our current idea is to expose the endpoint events not as a single callback, but as an (overflowing, non-lagging) broadcast stream. This would very much simplify the composition of protocols, as users won't have to merge their event listeners into a single callback, which needs to be passed to MagicEndpointBuilder (thus before MagicEndpoint exists, which makes the current state lead to chicken-and-egg problems)

@dignifiedquire
Copy link
Contributor

#1847 should help to improve the startup story

@Frando
Copy link
Member Author

Frando commented Apr 15, 2024

Closing this. Needs more thought and is not on the immediate agenda.

@Frando Frando closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants