validation: Disable CheckForkWarningConditions for background chainstate

The comparison of m_best_invalid with the tip of the respective chainstate makes no sense for the background chainstate, and can lead to incorrect error messages.
mzumsande · Sep 24, 2024 · 88ac1d0 · 88ac1d0
1 parent 06a539f
commit 88ac1d0
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/validation.cpp b/src/validation.cpp
@@ -2018,6 +2018,10 @@ void Chainstate::CheckForkWarningConditions()
 {
     AssertLockHeld(cs_main);
 
+    // Not applicable to the background chainstate
+    if (GetRole() == ChainstateRole::BACKGROUND) {
+        return;
+    }
     // Before we get past initial download, we cannot reliably alert about forks
     // (we assume we don't get stuck on a fork before finishing our initial sync)
     if (m_chainman.IsInitialBlockDownload()) {