Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a custom timezone to delorean.now(). #102

Merged
merged 3 commits into from
Oct 30, 2018
Merged

Allow passing a custom timezone to delorean.now(). #102

merged 3 commits into from
Oct 30, 2018

Conversation

deepbrook
Copy link

No description provided.

@myusuf3
Copy link
Owner

myusuf3 commented Oct 9, 2018

Mind updating associated documentation?

@deepbrook
Copy link
Author

deepbrook commented Oct 10, 2018

Not at all! Is there other documentation than the doc string that needs updating?

The doc string I already updated (you're a bit inconsistent when it comes to documenting parameters - but if you prefer documenting the parameters as well, I'll gladly do so).

@myusuf3
Copy link
Owner

myusuf3 commented Oct 12, 2018

If you could!

@myusuf3
Copy link
Owner

myusuf3 commented Oct 24, 2018

I want to merge this in, has it been tested as well?

@deepbrook
Copy link
Author

@myusuf3 - I relied on your tests to check it; However, a manual check using the cli worked for me.

@myusuf3 myusuf3 merged commit 9532dd5 into myusuf3:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants