Add opt-in support for the commit-msg hook #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does revise target a certain minimum git version? There are various ways to get the "hooks" path, newer versions have |
|
I don't think we guarantee any specific minimum git version. I personally am OK with this optional feature requiring a very recent Git. I think |
totph
force-pushed
the
msghook
branch
2 times, most recently
from
967e886 to
a37f7c8
Compare
|
Turns out the Also added |
Enabled via the boolean config option revise.run-hooks.commit-msg. Works in git worktrees and respects core.hooksPath.
rwe
added a commit
to rwe/git-revise
that referenced
this pull request
Sep 30, 2021
Instead of manually resolving from `self.workdir /`. According to mystor#82 (comment), the current minimum supported git version is 2.5 or 2.7.3. This means we can use --absolute-git-dir, which was introduced in 2.13. --path-format=absolute was introduced in git 2.31.0, which at the time of this writing is very recent, so a comment has been added to update that remaining case when it's appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled via the boolean config option revise.run-hooks.commit-msg