Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: lint replaceBy messages #147

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Fix: lint replaceBy messages #147

merged 2 commits into from
Jan 3, 2019

Conversation

LitoMore
Copy link
Contributor

@LitoMore LitoMore commented Jan 3, 2019

@mysticatea
Copy link
Owner

Thank you for the fix!

Would you fix the CI failure? (probably it will be fixed with eslint --fix)

@LitoMore
Copy link
Contributor Author

LitoMore commented Jan 3, 2019

OK, checking...

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #147 into master will decrease coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   98.21%   97.75%   -0.47%     
==========================================
  Files          64       40      -24     
  Lines        1123      890     -233     
==========================================
- Hits         1103      870     -233     
  Misses         20       20
Impacted Files Coverage Δ
lib/rules/no-deprecated-api.js 100% <ø> (ø) ⬆️
lib/util/exists.js 91.3% <0%> (-4.35%) ⬇️
lib/util/check-unsupported-builtins.js
tests/lib/rules/prefer-global/text-encoder.js
lib/rules/prefer-global/url-search-params.js
tests/lib/rules/prefer-global/process.js
lib/rules/prefer-global/text-decoder.js
lib/util/check-prefer-global.js
lib/util/get-semver-range.js
lib/rules/no-unsupported-features/es-builtins.js
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153ab03...11e0685. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 3, 2019 •
edited
Loading

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          64       64           
  Lines        1123     1123           
=======================================
  Hits         1103     1103           
  Misses         20       20
Impacted Files Coverage Δ
lib/rules/no-deprecated-api.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153ab03...11e0685. Read the comment docs.

@LitoMore LitoMore changed the title Fix: lint replaceBy messages Fix: update replaceBy messages Jan 3, 2019
@LitoMore LitoMore changed the title Fix: update replaceBy messages Fix: lint replaceBy messages Jan 3, 2019
@LitoMore
Copy link
Contributor Author

LitoMore commented Jan 3, 2019

@mysticatea Updated :)

@LitoMore
Copy link
Contributor Author

LitoMore commented Jan 3, 2019

Looks the test coverage has dropped, do I need to fill up the tests for the Node.js 10.0.0 cases?

@mysticatea
Copy link
Owner

LGTM, thank you very much!

@mysticatea mysticatea merged commit 62ba642 into mysticatea:master Jan 3, 2019
@LitoMore LitoMore deleted the fix-api-replacement branch January 3, 2019 11:15
@dependabot dependabot bot mentioned this pull request Mar 13, 2021
Closed
brettz9 pushed a commit to brettz9/eslint-plugin-node that referenced this pull request Jul 24, 2024
@scagood @aladdin-add
feat!: Start using enhanced-resolve to improve ts support (mysticat…
dc9f473 
…ea#139)

* feat: Use enhanced-resolve for imports

* chore: Improve the metadata from "ImportTarget"

* chore: remove "enhanced-resolve" from "no-hide-core-modules"

* test: Add a test for mysticatea#66

* feat!: Allow ts paths aliases (mysticatea#84)

* feat: Allow for "allowImportingTsExtensions" (mysticatea#134)

* feat: Add test for import maps (mysticatea#147)

* Update lib/util/import-target.js

Co-authored-by: Sebastian Good <[email protected]>

* test: Add test for n/no-missing-require eslint/use-at-your-own-risk

* chore: Remove esbuild

* feat: Allow for settings.cwd to be used before process.cwd

* chore: replace reference to eslint/use-at-your-own-risk

* chore: Remove more unused packages

* chore: update rule test options to flat config

* fix: incorrect env in tests

---------

Co-authored-by: 唯然 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LitoMore @mysticatea