Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for eslint-disable-line block comments and directive comments with descriptions. #43

Merged
merged 2 commits into from
May 17, 2020
Merged

Add support for eslint-disable-line block comments and directive comments with descriptions. #43

merged 2 commits into from
May 17, 2020

Conversation

ota-meshi
Copy link
Contributor

close #41
close #42

@ota-meshi ota-meshi mentioned this pull request May 11, 2020
Merged
@mysticatea mysticatea self-requested a review May 12, 2020 12:54
mysticatea
mysticatea approved these changes May 16, 2020
View reviewed changes
Copy link
Owner

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

I'm sorry, I have updated the CI to GitHub Actions. Would you resolve conflict?

@ota-meshi ota-meshi force-pushed the block-disable-line branch from 2b34e17 to 9e8bf86 Compare May 16, 2020 22:27
@ota-meshi ota-meshi force-pushed the block-disable-line branch from 9e8bf86 to 233574c Compare May 16, 2020 22:31
@ota-meshi
Copy link
Contributor Author

@mysticatea Thank you for checking this PR.
I rebased this PR to resolve the conflict.

@mysticatea mysticatea merged commit 027e20c into mysticatea:master May 17, 2020
@mysticatea
Copy link
Owner

Thank you!

@ota-meshi ota-meshi deleted the block-disable-line branch May 17, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

Assignees
No one assigned
Labels
accepted bug
Projects
None yet
Milestone
No milestone
2 participants
@ota-meshi @mysticatea