Implement Tunnel Configuration Check Feature #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmacan23
reviewed
Dec 17, 2024
dmacan23
approved these changes
Dec 17, 2024
Waldz
reviewed
Dec 18, 2024
| return | ||
| } | ||
| Logger.main.debug("Connection configuration: \(cfg)") | ||
| Task { | ||
| do { | ||
| mgr.isEnabled = true |
There was a problem hiding this comment.
What is the point to do check before connect if we have separate methods to check before it?
There was a problem hiding this comment.
In case the tunnel had gotten disabled, re-enable and save it, then connect.
There was a problem hiding this comment.
But it should as the pseudo code on application side:
if !checkTunnelConfiguration() {
setupTunnel()
}
connect()
There was a problem hiding this comment.
Yes correct, but if checkTunnelConfiguration returns true that means tunnel manager exists, but the tunnel can be disabled from system in some cases so it needs to be re-enabled before connecting.
Waldz
approved these changes
Dec 18, 2024
| @@ -82,7 +96,6 @@ void CALLBACK ConnectionStatusObserver::ServiceNotifyCallback(void* ptr) { | |||
| std::unique_ptr<flutter::StreamHandlerError<flutter::EncodableValue>> ConnectionStatusObserver::OnListenInternal( | |||
| const flutter::EncodableValue* arguments, std::unique_ptr<flutter::EventSink<flutter::EncodableValue>>&& events) { | |||
| sink_ = std::move(events); | |||
| // sink_->Success(flutter::EncodableValue(ConnectionStatusToString(ConnectionStatus::disconnected))); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.