Closes #165. Use native types for primitives. #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past, collision between the Myst-level type `Value` and Crystal's native `Value` class has been cumbersome (requiring namespacing as `Myst::Value`). Renaming to `MTValue` clears that confusion, and makes it more obvious where we're talking about Myst values.
…d `MutableValue`s. Instead of using wrapper classes for the primitive types of `TInteger`, `TFloat`, `TString`, and `TBoolean`, these values are now implemented directly as the underlying Crystal types: `Int64`, `Float64`, `String`, and `Bool` respectively. `TList` and `TMap` may also be converted over to use `Array` and `Hash` directly in the near future. `TNil` and `TSymbol` will remain non-native types. `TNil` will remain because it would conflict in many cases with Crystal's standard library returning `nil` in many cases (this is already enough of an issue with `false`). `TSymbol` needs to remain to be able to retain the name of the Symbol at run time. There are two main reasons for implementing this change: - **Performance improvements.** While not overly substantial (~0.1% speed-wise in a super-quick test benchmark), the interpreter no longer needs to allocate a whole object on the heap to represent integers, floats, or booleans (strings will still be allocated on the heap). In the long run, this will help with both speed and memory. - **Cleaner native library work.** Native library methods no longer need to wrap and unwrap values to work with them. Since these values are literally the Crystal objects themselves, they can be manipulated directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integer,Float,Boolean, andStringare now all implemented directly by Crystal's nativeInt64,Float64,Bool, andStringtypes.#165 covers most of what went into the implementation changes, so I won't bother repeating it here. The only difference is that instead of changing how type lookup works, the native types have been re-opened to add the needed
type_name,truthy?, andivarsproperties on them. For these types, referring toivarswill raise an exception.