Fixes #156. Fix callstack management and display. #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e execution.
`add_breakpoint` adds a method with the given name to the given Interpreter to allow specs to make arbitrary assertions and track arbitrary state _while_ a program is running.
This is particularly helpful when testing things like callstacks or `self` stack values, where the values don't exist/aren't relevant after execution has finished. With this approach, the "breakpoint" method can be called at any point in the Myst code being tested, and the spec will have access to the program's state at that point in the execution.
Example:
require "../support/breakpoints.cr"
it "Testing" do
itr = Interpreter.new
add_breakpoint(itr, "breakpoint") do |this, args, block|
__args[0].should be_a(TInteger)
end
parse_and_interpret! %q(
[1, 2, 3].each do |e|
breakpoint(e)
end
), interpreter: itr
end
This commit overhauls how the callstack is managed throughout the interpreter, hopefully fixing myst-lang#156 and preventing unwanted leaks from `raise`, `return`, etc. To accomplish this, this commit also adds a few other changes: - Add missing location information to flow control nodes while parsing. - Add a `name` property to `TFunctor` objects, used for display in backtraces. - Improve colorization of callstack output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls how the callstack is managed throughout the interpreter, hopefully fixing #156 and preventing unwanted leaks from
raise,return, etc.To accomplish this, this commit also adds a few other changes:
nameproperty toTFunctorobjects, used for display in backtraces.add_breakpointfor for executing arbitrary Crystal code during execution of a Myst program in Specs.