Problem Nesting blocks from static method

[bmulvihill]

The follow code raises an error that seems to stem from a scope issue:

deftype Test
  defstatic hello(&block)
    block()
  end
end

i = 0

Test.hello do
  10.times do
    i += 1
  end
end

Uncaught Exception: No variable or method i for Test:Test

[faultyserver]

Very interesting. I don't really have any idea what would be causing this. You mentioned in discord that it works when the method is an instance method rather than a static method, which pretty much rules out my initial thought of doubly-nested blocks just having issues with closures over the root scope.

I'll try to look more into this tomorrow afternoon.

[faultyserver]

I wonder if this could be an issue with scope vs instance_scope on Types. See this code:

myst/src/myst/interpreter/nodes/def.cr

Lines 4 to 15 in 2fd6706

	scope =
	case {type = current_self, node.static?}
	when {TType, true}
	type.scope
	when {TType, false}
	type.instance_scope
	when {Value, true}
	# Any other kind of value is not allowed to define static methods.
	raise "Cannot define static method on #{__typeof(current_self).name}"
	else
	current_scope
	end

Maybe scope doesn't have the same parent as instance_scope, and so it loses lexical context? That shouldn't be an issue though, because block should close over the lexical scope, not the semantic one.

[faultyserver]

My suspicion that this has something to do with static vs instance scopes has been furthered by the fact that this works when Test is a module instead of a type:

defmodule Test
  def hello(&block)
    block()
  end
end

i = 0

Test.hello do
  10.times do
    i += 1
  end
end

IO.puts(i) #=> 10

Going to properly start looking into this now.