Skip to content

Commit

Permalink
Fix for Bug#91550 (Bug#28297874), DatabaseMetaData specifies incorrec…
Browse files Browse the repository at this point in the history
…t extra name characters.

Change-Id: Ide79a36b62548b16f98f3dc8d824daab7d2d28d9
  • Loading branch information
Axyoan Marcelo committed Feb 3, 2024
1 parent e558e11 commit 832994a
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

Version 8.4.0

- Fix for Bug#91550 (Bug#28297874), DatabaseMetaData specifies incorrect extra name characters.

- Fix for Bug#113129 (Bug#36043145), setting the FetchSize on a Statement object does not affect.

- Fix for Bug#22931632, GETPARAMETERBINDINGS() ON A PS RETURNS NPE WHEN NOT ALL PARAMETERS ARE BOUND.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2002, 2023, Oracle and/or its affiliates.
* Copyright (c) 2002, 2024, Oracle and/or its affiliates.
*
* This program is free software; you can redistribute it and/or modify it under
* the terms of the GNU General Public License, version 2.0, as published by the
Expand Down Expand Up @@ -2607,7 +2607,7 @@ void forEach(String dbStr) throws SQLException {

@Override
public String getExtraNameCharacters() throws SQLException {
return "#@";
return "$";
}

/**
Expand Down
13 changes: 12 additions & 1 deletion src/test/java/testsuite/regression/MetaDataRegressionTest.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2002, 2023, Oracle and/or its affiliates.
* Copyright (c) 2002, 2024, Oracle and/or its affiliates.
*
* This program is free software; you can redistribute it and/or modify it under
* the terms of the GNU General Public License, version 2.0, as published by the
Expand Down Expand Up @@ -5578,4 +5578,15 @@ void testBug96582() throws Exception {
assertEquals(ParameterMetaData.parameterNullable, this.pstmt.getParameterMetaData().isNullable(2));
}

/**
* Tests fix for Bug#91550 (Bug#28297874), DatabaseMetaData specifies incorrect extra name characters.
*
* @throws Exception
*/
@Test
void testBug91550() throws Exception {
DatabaseMetaData md = this.conn.getMetaData();
assertEquals("$", md.getExtraNameCharacters());
}

}

0 comments on commit 832994a

Please sign in to comment.