Contact page

[zarino]

Connects to mysociety/alaveteli#74.

To-do:

• Reject form unless "I understand" checkbox has been checked.
• Form error handling – validation errors should be displayed in the correct place, the last houdini-input should be "checked" so the form is visible, and the user should be sent down to the #wdtk anchor.
• Hide "Contact" section of sidebar.
• Welsh translation.
• Nicer error message for not checking the box

[lizconlan]

@zarino - could you check I've not broken your design before I hand this over for a review of the Rails code?

[zarino]

@lizconlan – This return path should include the "#wdtk" location fragment, so that when they return to the contact page after logging in, they're automatically taken down to the right section of the page.

[zarino]

@lizconlan – I've added a few commits tidying up the error styles, but other than that, it all looks good!

[lizconlan]

@zarino I got a bit confused (easily done, admittedly) when there were "required" form fields as it just seemed as though the form was broken - I missed the visual cue of the disable submit button and was wondering why nothing was happening when I clicked on it. Although to be fair, I was expecting me to have broken something so...

[lizconlan]

Have fixed the post signin redirect. But... the client-side validation doesn't work in Safari, it just looks like the form submit's broken.

[zarino]

Sigh. Safari (on Mac and iOS) doesn't show a notification when a required form input is left empty: http://caniuse.com/#search=required (webkit bug from 7 years ago).

It is, however, beneficial for users with more compliant browsers, because it saves the page having to reload before you see your mistake.

Maybe we use JavaScript to remove the "required" attribute on Safari only? Would the form submit then?

[lizconlan]

7 year old bug in Safari, you say? Wish I could be more surprised. Yeah that should work - the only other thing I can think is to make the disabled submit button more obvious but that's probably harder/more disruptive.

[zarino]

Yes, we should aim to avoid the submit button being disabled at all. If that means we have to remove form validation entirely for all browsers, just so that it works for Safari, then so be it. But it'd be nice if we could just remove it for Safari, and keep it for the more modern browsers.

[lizconlan]

A bit clunkily done - if I say so myself - but should be Safari-proof now

[garethrees]

Clicking this redirects you to the homepage, You want select_authority_path.

[lizconlan]

D'oh! Thanks

[lizconlan]

(ah, that's been copied across from the original and is what's currently on the site - good catch @garethrees)

[garethrees]

Couple of minor bits but after that good to go. Lets handle the Welsh translations as part of mysociety/alaveteli#3137, as there'll be some additional translation to do there.

[garethrees]

Assigned to @lizconlan to handle minor fixups and merge