[#1267] Link NI charities to the Charity Commission for Northern Ireland database #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysociety-pusher
force-pushed
the
1267-add-ni-charity-link
branch
from
be7fac6 to
259586f
Compare
mdeuk
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Haven't explicitly tested, but per #1267 (comment) this LGTM. Thanks for the quick turnaround! 👍
garethrees
commented
Aug 3, 2022
mdeuk
approved these changes
Aug 4, 2022
The NI Charity Commission site only accepts the numeric part of the ID (i.e. without the "NIC" prefix), so we need to strip that for the query param. Fixes #1267.
mysociety-pusher
force-pushed
the
1267-add-ni-charity-link
branch
from
55f8ebb to
b33190f
Compare
garethrees
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1267.