Skip to content

Commit

Permalink
Merge branch 'uk-excluded_calculated_home_page_domains'
Browse files Browse the repository at this point in the history
gbp committed Oct 19, 2023
2 parents 6217d9e + 9f91e1c commit 6356382
Showing 2 changed files with 32 additions and 0 deletions.
17 changes: 17 additions & 0 deletions lib/model_patches.rb
Original file line number Diff line number Diff line change
@@ -73,6 +73,23 @@ def late_calculator
prepend ProAccountBans::ModelMethods
end

PublicBody.excluded_calculated_home_page_domains += %w[
aol.co.uk
blueyonder.co.uk
btconnect.com
btinternet.com
btopenworld.com
hotmail.co.uk
live.co.uk
ntlworld.com
sky.com
talk21.com
talktalk.net
tiscali.co.uk
virginmedia.com
yahoo.co.uk
]

PublicBody.class_eval do
# Return the domain part of an email address, canonicalised and with common
# extra UK Government server name parts removed.
15 changes: 15 additions & 0 deletions spec/public_body_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
require_relative 'spec_helper'

RSpec.describe PublicBody do
describe '.excluded_calculated_home_page_domains' do
subject { described_class.excluded_calculated_home_page_domains }

it 'includes default global domains' do
is_expected.to include('aol.com')
end

it 'includes expected localise domains' do
is_expected.to include('aol.co.uk')
end
end
end

0 comments on commit 6356382

Please sign in to comment.