Add mailchimp opt-in uploader #1850
Conversation
- Add supporting functions - Add basic User model
ajparsons
force-pushed
the
contact-io
branch
from
740aec9 to
548de2d
Compare
- Upload optins to relevant mailchimp lists daily
ajparsons
force-pushed
the
contact-io
branch
from
548de2d to
7a73f59
Compare
| from ..common.enum_backport import StrEnum | ||
| from .model_helper import UnmanagedDataclassModel, field | ||
|
|
||
| datetime_min = datetime.datetime(1, 1, 1, 0, 0, 0) |
| client = MailChimpHandler(config.MAILCHIMP_API_KEY) | ||
|
|
||
| # get internal id for the mailing list | ||
| mailing_list_id = client.list_name_to_unique_id(mailing_list_name) |
There was a problem hiding this comment.
I mean, it doesn't matter apart from the fact I have to deal with inefficient bots bringing down our services and so I don't want to ever be thought of as something like that, but can we call this once rather than 4 times (once per option, then again in line 65 before the batch add? :)
| @@ -0,0 +1,59 @@ | |||
| from typing import Any, Callable, TypeVar | |||
There was a problem hiding this comment.
I don't understand the typing but I'm sure it's lovely
| @@ -0,0 +1,686 @@ | |||
| import datetime | |||
There was a problem hiding this comment.
Sorry, this is quite a big file and lots of it doesn't appear to be used by this PR. Do you want me to review the whole file? Seems to be quite a lot of repetitive boilerplate, e.g. list_name_to_unique_id/ segment_name_to_unique_id/ template_name_to_unique_id all seem to do the same thing, just on a different thing; I don't see why MailchimpHandler has to call top-level functions of exactly the same name with all the arguments having to be repeated, that kind of thing. I'm sure it's all fine 🤷
This PR is a simplified version of #1813
Currently we have contact optins when people create accounts, but we don't automatically move them to mailchimp.
This adds uploading new registrations from yesterday to the mailchimp account.
This also adds a basic django ORM approach to accessing the TWFY database from python.
It needs a new MAILCHIMP_API_KEY in the config.