Improve design of alerts page #1837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struan
force-pushed
the
alert-front-end-existing-functionality
branch
8 times, most recently
from
e2cd2de to
6bd28e2
Compare
struan
force-pushed
the
alert-front-end-existing-functionality
branch
from
6bd28e2 to
c861390
Compare
Useful for doing DB things in development
Makes it easier to split out the different alert types on the alert page. Splits them into alerts with keywords, alerts for when someone speaks and alerts for the user's members.
To make it a bit easier to pick out the different parts of an alert update prettifyCritera to return the parts as a hash instead of turning it into a string.
Move things from the sidebar to the main section and update the look to split out alerts into keyword and representative alerts. Generally improve the look of them.
Also split them out and include as key in alert object so we can use them in alerts interface
|
Closing in favour of #1851 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR in a series to update the look of the alerts page. It only updates the display of existing alerts and not the creation etc. It splits alerts into keyword alerts and representative alerts, although x is mentioned alerts still count as keyword alerts for now.
It doesn't really touch any of the back end other to add some extra properties to alert objects.
It's also missing any translations for the new text.
I'm not proposing this is merged, but is used as the first part of several which will include changes to the alert creation UX.
Part of #1824