Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update summary page #1773

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Update summary page #1773

merged 5 commits into from
Mar 20, 2024

Conversation

ajparsons
Copy link
Contributor

@ajparsons ajparsons commented Mar 4, 2024

As we've now moved the voting summary out of the main page, we want something to take its place when people get to the MP page after entering their postcode.

Intro to MP

This introduces a basic "intro to your MP" page, that we can expand later - basic links to other mySociety services.

This also switches around the profile and the recent appearances - ideally we'd be moving the recent appearance into its own tab - so that it's a bit towards for the bottom for the moment is fine. More aspects of the profile might move into the 'intro' paragraph.

image

Abstract person navigation

This menu is now shared between the various views - being clearer about the logic of what is and isn't included for different kinds of representative rather than this being implicit in who did or didn't have various options enabled.

Technically not needed for this PR - but is a stepping stone towards moving the register and recent appearances into their own fuller pages.

image

This fixes #1771 and also enables the 'recent votes' menu (which worked but wasn't linked) for devolved reps:

image

@ajparsons ajparsons force-pushed the update-summary-page branch 2 times, most recently from 3cc814b to 66b9e86 Compare March 5, 2024 10:11
@ajparsons ajparsons changed the base branch from master to voting-copy-changes March 5, 2024 10:27
@ajparsons ajparsons force-pushed the update-summary-page branch 3 times, most recently from 2bf6494 to 502c64b Compare March 5, 2024 10:58
@ajparsons ajparsons requested a review from dracos March 5, 2024 11:01
@ajparsons ajparsons force-pushed the voting-copy-changes branch 4 times, most recently from e0a7c10 to f3f1db8 Compare March 14, 2024 15:55
@ajparsons ajparsons force-pushed the update-summary-page branch from 502c64b to 86b868a Compare March 14, 2024 16:38
@ajparsons ajparsons force-pushed the voting-copy-changes branch from 4d9eb20 to 0313d31 Compare March 15, 2024 11:17
New EDM link needs access to party ID
- Enables recent vote page for devolved representatives
- Enable votes link for all except NIA and LA
@ajparsons ajparsons force-pushed the update-summary-page branch from 86b868a to c3c0ac4 Compare March 15, 2024 11:18
@ajparsons ajparsons merged commit 7439ff8 into voting-copy-changes Mar 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants