Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert voting information help page to markdown document #1764

Merged
merged 6 commits into from
Feb 22, 2024

Conversation

ajparsons
Copy link
Contributor

Add approach for rendering of a markdown document as a help page.

For the moment, the text is unchanged - the page itself isn't an exact replica as it loses the multiple cards, but that's fine.

The end goal is making it easier for changes and tweaks to the text , making it easier to add similar pages to the site, and an approach that can be taken over to WriteToThem too.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small things

classes/Renderer/Markdown.php Outdated Show resolved Hide resolved
classes/Renderer/Markdown.php Show resolved Hide resolved
classes/Renderer/Markdown.php Outdated Show resolved Hide resolved
@ajparsons ajparsons requested a review from dracos February 22, 2024 11:26
@ajparsons
Copy link
Contributor Author

This should now be almost exactly in sync style wise. Using markdown's HR support to create new panels.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can probably all be squashed

@ajparsons ajparsons merged commit 6fa404c into master Feb 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants