Seperate out phpdoc to docker based action #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
approved these changes
Feb 9, 2024
|
I've removed the dependency and all the tests seem fine - so will merge that as well. |
|
You could also have removed build-docs.sh :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's something wrong with the current phpdoc process - I think it's a dependency versioning issue that will go away when we upgrade the PHP version to 8 at some point and can use the newer version.
BUT - we can also just move all of this into github actions. This creates a new action that uses the docker version of phpdoc and uploads directly to github pages without pushing back to a branch.
(In principle if we stick with this we could remove the dependencies from the repo, but also it seems fine)