Add TWFY_VOTES_URL to docker config #1760
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Populate the php setting from an env var.
ajparsons
force-pushed
the
default-twfy-votes-url
branch
from
58d1728 to
78f2887
Compare
dracos
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the prepopulate scripts depend on having the variable set, but at the moment we're not storing it in the config because it's not the final URL.
This passes through a variable from codespaces secrets to the docker container, and to the php config, which lets the prebuild process gather all the data needed.
(In principle the url will then be available through the prebuild - but as it's not secret secret this is fine)