1738 move votes from profile page #1756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty IN, bool ints, strict group by.
Need to turn off deprecation warnings for tests to pass (e.g. some output in the middle of a string being tested on), but will need to be reactivated and issues fixed before PHP9.
The way it gets read in by other languages can cause an "array to string" notice.
|
This works as I'd expect - the one thing I'm thinking about is if we need to keep the boilerplate when someone has no significant differences - e.g. to say the 'they are a blah MP, and generally vote like other blah MPs. In all policy areas below, they have generally voted the same as their party' bit. Will have a think. |
- Given this is the most common thing, we want a box to be able to talk about it.
ajparsons
approved these changes
Jan 4, 2024
dracos
force-pushed
the
upgrade-phpunit
branch
from
9a47a84 to
2d9398c
Compare
Merged
|
Closing this one in favour of #1774 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1738, I think.