fixup! Display agreements in detailed policy page

mysociety · Feb 8, 2024 · ededb78 · ededb78
1 parent 0001007
commit ededb78
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/classes/Policies.php b/classes/Policies.php
@@ -61,7 +61,7 @@ public function __construct($policy_id = null) {
             6672,
         );
 
-        $this->all_policy_agreements = $policy_data['agreements'];
+        $this->all_policy_agreements = $policy_data['agreements'] ?? [];
 
         if ( $policy_id ) {
             $this->policy_id = $policy_id;

diff --git a/www/docs/mp/index.php b/www/docs/mp/index.php
@@ -441,7 +441,7 @@
 
         if ( $policyID ) {
             $data['policydivisions'] = $divisions->getMemberDivisionsForPolicy($policyID);
-            $rel_agreements = $policiesList->all_policy_agreements[$policyID];
+            $rel_agreements = $policiesList->all_policy_agreements[$policyID] ?? [];
             // filter down to where 'date' is within the member's term
             // This won't be perfect where the member has been in and out of the house
             // But it doesn't affect their score.

diff --git a/www/includes/easyparliament/templates/html/mp/divisions.php b/www/includes/easyparliament/templates/html/mp/divisions.php
@@ -54,7 +54,7 @@
                         foreach ($policydivisions as $policy) { ?>
 
                             <?php
-                                $current_policy_agreements = $policyagreements[$policy['policy_id']];
+                                $current_policy_agreements = $policyagreements[$policy['policy_id']] ?? [];
                                 $divisions_scoring = [];
                                 $divisions_informative = [];
                                 $agreements_scoring = [];