Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 constituencies #173

Merged
merged 3 commits into from
Jul 4, 2024
Merged

2024 constituencies #173

merged 3 commits into from
Jul 4, 2024

Conversation

dracos
Copy link
Member

@dracos dracos commented Jul 1, 2024

This removes the duplicate JSON data handling of constituencies, and adds the 2024 constituencies (with MapIt ID, but open to sticking a different ID in, or no idea, we generally go on name).

@ajparsons
Copy link
Contributor

Looks good - I checked the new GSS codes were the right ones and follow the rest of the changes. Makes sense to reduce any duplicate files.

@dracos
Copy link
Member Author

dracos commented Jul 2, 2024

Sorry, I've just added the changes here to have the update script work with DC's current CSV file.

@dracos dracos force-pushed the 2024-constituencies branch 2 times, most recently from 0154679 to b57a373 Compare July 2, 2024 20:40
@dracos dracos force-pushed the 2024-constituencies branch from b57a373 to 7643d17 Compare July 4, 2024 11:12
@dracos dracos merged commit 7643d17 into master Jul 4, 2024
1 check passed
@rbairwell
Copy link

Hi,

I've just noticed that the removal of the members/constituencies.json file in this commit ( f250e35 ) has broken the PublicWhip import system. Is there any chance of resurrecting this file?

@dracos
Copy link
Member Author

dracos commented Jul 31, 2024

@rbairwell The same data was in that file and in people.json, so given we had to add 650 new constituencies anyway, I didn't want to add it in two places :) I've opened publicwhip/publicwhip#40 which should hopefully help get you to the new source (even if I'd kept the old file, you'd still have the encoding issue I mention there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants