Show updates pending alert on list page. #124
Conversation
Codecov Report
@@ Coverage Diff @@
## merge-modified-updates #124 +/- ##
==========================================================
- Coverage 100.00% 99.97% -0.03%
==========================================================
Files 85 86 +1
Lines 3558 3617 +59
==========================================================
+ Hits 3558 3616 +58
- Misses 0 1 +1
Continue to review full report at Codecov.
|
dracos
force-pushed
the
merge-modified-updates
branch
from
455c554 to
af5ea5b
Compare
dracos
force-pushed
the
show-updates-waiting
branch
from
8590c7c to
d20b524
Compare
- Position at the top of the list makes it clearer that the "updates" refers to the list content, and more closely resembles how other websites (eg: social media) display their update notifications. - aria-live="polite" enables screenreaders to monitor and announce the number of updates, when it changes.
I was surprised that .lbh-link--no-visited-state didn’t use an !important flag, so would often be overridden by more specific component styles – which is exactly the opposite of what you’d want from a specific utility class like this. Replacing the @extend with our own :visited definition allows us to add the !important flag.
|
From Slack: "I made it pos:absolute so it wouldn't shift the page when it appeared in case you were about to click on something (because it's horrible when that happens). Any chance we can do it in a banner way that doesn't shift anything already there?" "now you make me think about it again, I realise that on a busy day/night, you’re probably guaranteed to see a “new updates” banner 30 seconds after every pageload, because stuff will be constantly happening" |
dracos
force-pushed
the
show-updates-waiting
branch
from
081e7d7 to
8eac199
Compare
Relies on the merge branch, and uses code from the auto-filter branch that could be refactored together.
Needs some tests, but thought it good to get it up for looking at. Very basic, just checks once every 30s.
If you have the list page open, then edit one of the cases, you should then see the update message appear.