Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conf variable for $vcspath_install #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gbp
Copy link
Member

@gbp gbp commented Apr 9, 2021

This would be useful when processing ugly files.

For example we could add:

!!(*
  my $pro = `grep ^ENABLE_ALAVETELI_PRO $vhost_dir/$vcspath_install/config/general.yml | grep true | sed -n '\$='` || 0;
)!!

This would allow us to workout if Alaveteli Pro is enabled and later
conditionally add to the crontab if enabled. Currently we manually
maintain a list of vhosts in the config_crontab.ugly file which is
easily missed when upgrading a vhost.

We can't use the existing $vcspath variable as this is the final symlink
location of the vhost path. We need access to the timestamped path as
the ugly file processing happens before the symlinking.

This would be useful when processing ugly files.

For example we could add:
!!(*
  my $pro = `grep ^ENABLE_ALAVETELI_PRO $vhost_dir/$vcspath_install/config/general.yml | grep true | sed -n '\$='` || 0;
)!!

This would allow us to workout if Alaveteli Pro is enabled and later
conditionally add to the crontab if enabled. Currently we manually
maintain a list of vhosts in the config_crontab.ugly file which is
easily missed when upgrading a vhost.

We can't use the existing $vcspath variable as this is the final symlink
location of the vhost path. We need access to the timestamped path as
the ugly file processing happens before the symlinking.
@sagepe
Copy link
Member

sagepe commented Apr 26, 2021

I don't see any reason not to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants