TheyWorkForYou and WriteToThem links in MP section on Area page #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 100 100
Lines 3021 3021
Branches 319 319
=======================================
Hits 2506 2506
Misses 436 436
Partials 79 79 ☔ View full report in Codecov by Sentry. |
struan
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
I do wonder about finding a better link for the election results than an API results page, although good to link directly to the data source. However, I wonder if adding a link to this page would also be good: https://electionresults.parliament.uk/election/2019-12-12/Results/Location/Constituency/Bermondsey%20and%20Old%20Southwark
zarino
force-pushed
the
382-twfy-wtt-links
branch
from
3fe3db8 to
7a0bd96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new "Email your MP about this data" link above MP section, and adds another link to TWFY voting record (this time, near to where we’re already displaying votes, which is a bit more intuitive).
Related to #382.