Theme changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define some colours, larger font size on menu, with underline on hover, same text colour on submenu, show focused inputs, no background by default in inputs. Don't make greeting text use background colour.
Command used: bundle exec rake gettext:find_theme
This theme is derived from http://tuderechoasaber.es, so needs an CC-SA compatible license.
Handling this in _footer_layout.scss
The production site only has one locale (at the moment).
We're constraining older IE to 58ems altogether.
|
Ready to review. Going to ask for a little bit of design time for:
|
|
+1. Only thing I really think needs attention is the nav current page highlight colour. |
|
@garethrees what browser do you see the search box expansion issue in? |
Chrome. Seems fine on Firefox |
|
Can't seem to replicate the search box issue in Chrome. Is it consistent across all pages? |
Looks like its only when you're signed in as an admin actually. Happens on all pages. |
|
|
|
Pre-click
post-click
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still to do: