Update national data import script to work for multiple years #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add an option to make setting up options optional
also change the config to being loaded from a json file instead of hard coded.
struan
force-pushed
the
202-update-national-data-import
branch
3 times, most recently
from
dab9b02 to
a6fea43
Compare
should make testing it a bit less fraught
No need for a council lookup so do not populate it and get the GSS code directly from the data sheet
Some sheets have data for, e.g. multiple years in and we only want one of them so update the skip logic to allow for skipping unless the column matches versus skipping if the column does not match
as we're not creating the options from script it makes more sense to match using the score than the description as then don't need to do a lot of redundant config
struan
force-pushed
the
202-update-national-data-import
branch
from
a6fea43 to
bc8c630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the file location and configuration arguments as well as moving the config into an external JSON file, plus adds support for marking sessions.
Finally, it does not set up question options by default.
Fixes #202