[#1005] Hide individual attachments #7391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to address points made in previous review #7327 (review) |
gbp
force-pushed
the
1005-hide-individual-attachments-2
branch
from
caafffe to
5fa6885
Compare
|
From #7327 (review)
This has now been fixed and separated out into its own commit in: 3f6a3f1 |
gbp
force-pushed
the
1005-hide-individual-attachments-2
branch
3 times, most recently
from
e778ace to
23baf65
Compare
|
From #7327 (review)
Fixed in 6c302bf |
garethrees
approved these changes
Oct 27, 2022
Allowing us to check if an attachment can be `read` by checking its prominence and if the incoming message and info request are also readable.
We need to check attachment prominence when rendering correspondence on the `request#show` action and views.
We need to check attachment prominence when serving them directly or when converted to HTML.
We need to check attachment prominence when adding them to request ZIP downloads or the text version of the correspondence.
We need to check attachment prominence while updating the Xapian search index for events. To achieve the `IncomingMessae#get_body_for_quoting` method needed to be split, as it was being used for both indexing and displaying the body as text.
Update an attachment prominence from the admin and record an `edit_attachment` event on the relevant request.
gbp
force-pushed
the
1005-hide-individual-attachments-2
branch
from
af23784 to
5939b59
Compare
This tests 27 different permutations of different prominences values for requests, messages and attachments objects. Proving that viewing requests and attachments is correctly limited and the correct prominence reason shown.
gbp
force-pushed
the
1005-hide-individual-attachments-2
branch
from
5939b59 to
0eaac67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Supersedes #7327
Fixes #1005
What does this do?
Allows admins to edit attachment prominence and reason.
Add prominence checks for attachments when:
Why was this needed?
Easier admin of responses and attachments.
Implementation notes
Screenshots
Notes to reviewer