Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1005] hide attachments prep #7387

Merged
merged 12 commits into from
Oct 24, 2022
Merged

[#1005] hide attachments prep #7387

merged 12 commits into from
Oct 24, 2022

Conversation

gbp
Copy link
Member

@gbp gbp commented Oct 24, 2022

Reviewed commits which have been extracted from #7327 - just checking these are green before pushing to develop.

gbp added 12 commits October 24, 2022 11:17
Move specs into shared example block so these can be included within
other model's specs.
Rename variable `message` to `prominenceable` as this will allow us to
use this partial for attachments as well as messages.
Update the attachment caching to take place after the authentication. In
changing this a regression for returning a 'Directory listing not
allowed' error is introduced.

In order to fix the routes have been tightened up so we can simply check
for the present of `file_name` parameter.

Fixes #6477
This is shared across all classes which include `MessageProminence` so
can be extracted.
@gbp gbp merged commit a71fd4c into develop Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant