[#1005] Preparation work before adding indivdual attachment prominence #7324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethrees
requested changes
Sep 27, 2022
gbp
force-pushed
the
1005-prep-for-attachment-prominence
branch
from
363c9e1 to
0b630ce
Compare
garethrees
reviewed
Sep 28, 2022
Fix: - Hash styling
The message body is passed through `simple_format` which, by defualt wraps in a `p` tag. Changes the surrounding tag to a `div` to prevent invalid HTML.
The bubble partial is mainly used to render incoming message attachments so if we don't use this for outgoing messages we can simplify rendering. The only useful element for outgoing messages is the correspondence container, this has been extracted out from the partial.
In helpers and views when linking to incoming or outgoing messages we manually generate anchors fragments. With minor changes we can replace the manual anchors with the `dom_id` helper.
gbp
force-pushed
the
1005-prep-for-attachment-prominence
branch
from
0b630ce to
9eb2ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Connected to #1005
What does this do?
app/views/request/_bubble.html.erbpartial, now assumed it will be passed an incoming message (instead of also handling outgoing messages).Why was this needed?
These changes will makes the changes required for #1005 smaller and simpler to review.